Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grace: ignore key up and fix typo #113

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

PaideiaDilemma
Copy link
Collaborator

@PaideiaDilemma PaideiaDilemma commented Mar 1, 2024

Fix typo and ignore key up

When you start hyprlock via a key press, then there is a stray key up event that would trigger the grace period unlock.
This is also notable because without ignoring key up also ran into a racy bug that is probably the same as #107. So unlocking the screen quickly after startup seems to trigger it. Did not figure out what is going on yet tough. That was because of locking a locked session

Fixes #112

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fufexan fufexan merged commit a7ec195 into hyprwm:main Mar 1, 2024
1 check passed
@PaideiaDilemma PaideiaDilemma deleted the quickfix-grace branch March 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compilation fails
2 participants