DBusManager: Remove unnecessary locks from getters in singleton

hyprwm · Jan 4, 2025 · b22009f · b22009f
1 parent 00b02c0
commit b22009f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/src/core/DBusManager.cpp b/src/core/DBusManager.cpp
@@ -33,28 +33,24 @@ void DBusManager::initializeConnection() {
 }
 
 std::shared_ptr<sdbus::IConnection> DBusManager::getConnection() {
-    std::lock_guard<std::mutex> lock(m_mutex);
     return m_pConnection;
 }
 
 std::shared_ptr<sdbus::IProxy> DBusManager::getLoginProxy() {
-    std::lock_guard<std::mutex> lock(m_mutex);
     if (!m_pLoginProxy)
         initializeConnection();
 
     return m_pLoginProxy;
 }
 
 std::shared_ptr<sdbus::IProxy> DBusManager::getSessionProxy() {
-    std::lock_guard<std::mutex> lock(m_mutex);
     if (!m_pSessionProxy)
         initializeConnection();
 
     return m_pSessionProxy;
 }
 
 void DBusManager::setLockedHint(bool locked) {
-    std::lock_guard<std::mutex> lock(m_mutex);
     if (!m_pSessionProxy) {
         Debug::log(WARN, "[DBusManager] Cannot set locked hint: Proxy is not initialized.");
         return;
@@ -71,7 +67,6 @@ void DBusManager::setLockedHint(bool locked) {
 }
 
 void DBusManager::sendUnlockSignal() {
-    std::lock_guard<std::mutex> lock(m_mutex);
     if (!m_pSessionProxy) {
         Debug::log(WARN, "[DBusManager] Unlock signal skipped: Proxy is not initialized.");
         return;

diff --git a/src/core/DBusManager.hpp b/src/core/DBusManager.hpp
@@ -2,7 +2,6 @@
 
 #include <memory>
 #include <string>
-#include <mutex>
 #include <sdbus-c++/sdbus-c++.h>
 
 class DBusManager {
@@ -25,6 +24,4 @@ class DBusManager {
     std::shared_ptr<sdbus::IConnection> m_pConnection;
     std::shared_ptr<sdbus::IProxy>      m_pLoginProxy;
     std::shared_ptr<sdbus::IProxy>      m_pSessionProxy;
-
-    std::mutex                          m_mutex;
 };