Add new Mention model #9258
Merged
Add new Mention model #9258
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomilov
force-pushed
the
create-new-table-to-store-mentions
branch
from
0405582 to
6628257
Compare
mtomilov
commented
Jan 20, 2025
acelaya
reviewed
Jan 20, 2025
mtomilov
commented
Jan 20, 2025
marcospri
approved these changes
Jan 20, 2025
h/models/mention.py
Outdated
| class Mention(Base, Timestamps): # pragma: nocover | ||
| __tablename__ = "mention" | ||
|
|
||
| id = sa.Column(sa.Integer, autoincrement=True, primary_key=True) |
There was a problem hiding this comment.
Although we don't have make typecheck on H yet we should aim to use the new style of declaring columns for new models:
mtomilov
force-pushed
the
create-new-table-to-store-mentions
branch
from
964eabe to
78ddfff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9259
Here we're adding a new
mentionmodel to support at-mentions project including alembic migration.