Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1059: Android topics search #789

Merged
merged 17 commits into from
Dec 15, 2023
Merged

ALTAPPS-1059: Android topics search #789

merged 17 commits into from
Dec 15, 2023
+604 −13

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Dec 14, 2023 •
edited by ivan-magda
Loading

YouTrack Issues:
ALTAPPS-1059

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Adds search screen on Android

Sorry, something went wrong.

@XanderZhu XanderZhu added shared Shared module task android Android module task labels Dec 14, 2023
@XanderZhu XanderZhu added this to the 1.45 milestone Dec 14, 2023
@XanderZhu XanderZhu self-assigned this Dec 14, 2023
@XanderZhu XanderZhu requested a review from ivan-magda December 14, 2023 15:40
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Dec 14, 2023
@XanderZhu XanderZhu marked this pull request as ready for review December 14, 2023 15:40
@ivan-magda

This comment was marked as resolved.

Sign in to view
@ivan-magda ivan-magda added awaiting changes Changes requested, waiting on author to update and removed awaiting review Pull Request is awaiting code reviews labels Dec 15, 2023
@XanderZhu
Copy link
Contributor Author

@ivan-magda
I decided to hide the search screen after navigation to the step screen because there was an animation problem while navigating back. To avoid animation problems and have a clear navigation flow I removed animations.

@XanderZhu XanderZhu added awaiting review Pull Request is awaiting code reviews and removed awaiting changes Changes requested, waiting on author to update labels Dec 15, 2023
@ivan-magda

This comment was marked as resolved.

Sign in to view
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Dec 15, 2023
@XanderZhu XanderZhu merged commit 6b1c652 into develop Dec 15, 2023
@XanderZhu XanderZhu deleted the feature/ALTAPPS-1059/android-topics-search branch December 15, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda

Assignees

@XanderZhu XanderZhu

Labels
android Android module task shared Shared module task
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XanderZhu @ivan-magda