Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1070: iOS add reminders time to notification onboarding #787

Merged
merged 20 commits into from
Dec 15, 2023
Merged

ALTAPPS-1070: iOS add reminders time to notification onboarding #787

merged 20 commits into from
Dec 15, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Dec 13, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-1070

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Updates notifications onboarding UI
  2. Adds daily study reminders start hour interval picker

@ivan-magda ivan-magda added this to the 1.45 milestone Dec 13, 2023
@ivan-magda ivan-magda self-assigned this Dec 13, 2023
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Dec 13, 2023
@ivan-magda
Update show modal & add missing analytic
119e24f
@ivan-magda
Merge branch 'feature/ALTAPPS-1069/shared-add-reminders-time-to-notif…
44308fb 
…ication-onboarding' into feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding
@ivan-magda ivan-magda removed shared Shared module task android Android module task labels Dec 13, 2023
@ivan-magda ivan-magda marked this pull request as ready for review December 13, 2023 17:13
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Dec 13, 2023
@ivan-magda ivan-magda requested a review from vladkash December 13, 2023 17:13
@ivan-magda
Merge branch 'develop' into feature/ALTAPPS-1069/shared-add-reminders…
a6a6554 
…-time-to-notification-onboarding
@ivan-magda
Merge branch 'feature/ALTAPPS-1069/shared-add-reminders-time-to-notif…
2ff279f 
…ication-onboarding' into feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding
@ivan-magda
Delete dailyStudyRemindersStartHour from ViewState
9086e31
@ivan-magda
Merge branch 'feature/ALTAPPS-1069/shared-add-reminders-time-to-notif…
408cce2 
…ication-onboarding' into feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding
@ivan-magda
Fix build
804046f
@ivan-magda
Merge branch 'develop' into feature/ALTAPPS-1069/shared-add-reminders…
28140b0 
…-time-to-notification-onboarding
@ivan-magda
Merge branch 'feature/ALTAPPS-1069/shared-add-reminders-time-to-notif…
ed01ebf 
…ication-onboarding' into feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding
@ivan-magda
Fix docs for NotificationsOnboardingDailyStudyRemindersIntervalPicker…
f7b1d9d 
…ModalClickedConfirmHyperskillAnalyticEvent
@ivan-magda
Merge branch 'feature/ALTAPPS-1069/shared-add-reminders-time-to-notif…
24922dd 
…ication-onboarding' into feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding
Base automatically changed from feature/ALTAPPS-1069/shared-add-reminders-time-to-notification-onboarding to develop December 15, 2023 04:40
@ivan-magda ivan-magda merged commit f1e80d7 into develop Dec 15, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1070/ios-add-reminders-time-to-notification-onboarding branch December 15, 2023 09:13
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladkash vladkash vladkash approved these changes

Assignees

@ivan-magda ivan-magda

Labels
ios iOS module task
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-magda @vladkash