Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1058: iOS search feature #784

Merged
merged 30 commits into from
Dec 13, 2023
Merged

ALTAPPS-1058: iOS search feature #784

merged 30 commits into from
Dec 13, 2023
+398 −14

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Dec 12, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-1058

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • View analytics events are added for new screens;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Adds Search module (available on iOS 15 and above)
  2. Presents search screen on gamification bar button item tap
  3. Updates gems statistics position in the ProfileView

Sorry, something went wrong.

@ivan-magda
Add SearchResultsDataComponent
32a5445
@ivan-magda
Delete TopicsInteractor
ef3afad
@ivan-magda
Gamification toolbar add search message
bf46e58
@ivan-magda
SearchFeature initial commit
8a42a19
@ivan-magda
Do search
8acff52
@ivan-magda
Add ViewState
5cb60dd
@ivan-magda
Handle click on search results item
e74e358
@ivan-magda
Handle retry search
641f30c
@ivan-magda
Reformat code
1379c83
@ivan-magda
Add empty view state
cd19f77
@ivan-magda
Add string resources
04c4dca
@ivan-magda
Fix SearchReducer.handleSearchClickedMessage
8115096
@ivan-magda
Update SearchResult.targetType
e2ed8c8
@ivan-magda
Merge branch 'feature/ALTAPPS-1057/shared-search-data-component' into…
c5ced23 
… feature/ALTAPPS-1057/shared-search-feature
@ivan-magda
Merge remote tracking branch origin/feature/search
0136852
@ivan-magda
Add OpenStepScreenFailed view action
040b781
@ivan-magda
Perform search requests while typing
385b9de
@ivan-magda
Add search bar button item
6a2c66a
@ivan-magda
Add search module
1b37dcf
@ivan-magda
Handle search query the same
7be1289
@ivan-magda
Delete isSearchButtonEnabled
38919e7
@ivan-magda ivan-magda added this to the 1.45 milestone Dec 12, 2023
@ivan-magda ivan-magda self-assigned this Dec 12, 2023
@github-actions github-actions bot added shared Shared module task ios iOS module task labels Dec 12, 2023
@ivan-magda ivan-magda changed the title ALTAPPS-1058: iOS search ALTAPPS-1058: iOS search feature Dec 12, 2023
@ivan-magda ivan-magda marked this pull request as ready for review December 12, 2023 11:32
@ivan-magda ivan-magda requested a review from vladkash December 12, 2023 11:32
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Dec 12, 2023
Base automatically changed from feature/ALTAPPS-1057/shared-search-feature to feature/search December 13, 2023 03:03
vladkash
vladkash approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@vladkash vladkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Dec 13, 2023
@ivan-magda ivan-magda merged commit ad6d6a2 into feature/search Dec 13, 2023
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1058/ios-search branch December 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladkash vladkash

Assignees

@ivan-magda ivan-magda

Labels
ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan-magda @vladkash