iOS: Fix NSInvalidArgumentException: Required value was nil in CodePlaygroundManager.swift #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-magda
deleted the
fix/1226-ios-crash-nsinvalidargumentexception-required-value-was-nil-in-codeplaygroundmanagerswift
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1226
This pull request includes several changes to the
CodePlaygroundManagerclass in theiosHyperskillAppproject, focusing on improving the method for converting a position to a text range in aUITextViewand updating the method calls accordingly.Method Renaming and Refactoring:
textRangeFrommethod totextRangeto improve readability and return an optionalUITextRangeinstead of a required one. (iosHyperskillApp/iosHyperskillApp/Sources/Frameworks/CodeEditor/Model/Analyze/CodePlaygroundManager.swift)Method Call Updates:
textRangemethod name and handle the optional return type appropriately. (iosHyperskillApp/iosHyperskillApp/Sources/Frameworks/CodeEditor/Model/Analyze/CodePlaygroundManager.swift)insertAtCurrentPositionto set theselectedTextRange.selectedTextRange.