Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openAPI mutability #1115 #1494

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: openAPI mutability #1115 #1494

wants to merge 2 commits into from

Conversation

yshyn-iohk
Copy link
Member

@yshyn-iohk yshyn-iohk commented Jan 10, 2025

Description:

This PR fixes issue #1115: OAS is mutated from build to build because of Instant.now() and UUID.random() functions were used in the annotations.

I tried to implement the integration tests, but it's not trivial and fragile because the Tapir OAS is static and a lot of classes must be reloaded or isolated in the dedicated classloader.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk requested a review from a team as a code owner January 10, 2025 12:06
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) January 10, 2025 12:14
Copy link
Contributor

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
55 tests ±0  55 ✅ ±0  0 💤 ±0  0 ❌ ±0 
97 runs  ±0  97 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 073a12d. ± Comparison against base commit 37a8f41.

Copy link
Contributor

Unit Test Results

104 files  ±0  104 suites  ±0   20m 27s ⏱️ + 3m 11s
882 tests ±0  874 ✅ ±0  8 💤 ±0  0 ❌ ±0 
889 runs  ±0  881 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 073a12d. ± Comparison against base commit 37a8f41.

@coveralls
Copy link

Coverage Status

coverage: 48.817% (+0.2%) from 48.642%
when pulling 073a12d on fix/1115
into 37a8f41 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants