Remove remote-node-url since connector info provided by tezosconnect.yml #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Semenyuk <[email protected]>
alex-semenyuk
requested review from
nguyer,
awrichar and
peterbroadhurst
as code owners
| if initOptions.RemoteNodeURL == "" { | ||
| return fmt.Errorf("you must provide 'remote-node-url' flag as local node mode is not supported") | ||
| if initOptions.ExtraConnectorConfigPath == "" { | ||
| return fmt.Errorf("you must provide 'connector-config' flag with path to 'tezosconnect.yml' config file") |
There was a problem hiding this comment.
Hey @alex-semenyuk, thanks for the PR!
'tezosconnect.yml' is not a required file, it overrides the default config of the service ('tezossigner.yaml').
'remote-node-url' option is required to initialise the default config, so it has higher priority over the 'tezosconnect.yml'.
There was a problem hiding this comment.
@denisandreenko thanks for clarification then we can close it but I raised one more to improve documentation on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently remote-node-url is required, but accordance to https://github.com/hyperledger/firefly/blob/4645f28a17f6ad813d0a9cbb39ba07d2a5cca795/docs/tutorials/chains/tezos_testnet.md?plain=1#L33C14-L33C30 we should provide tezosconnect.yml in which we have the same section. So left only section from config
^^ @denisandreenko