tests created for the Ethereum Blockchain node providers #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip-21 <[email protected]>
Philip-21
requested review from
nguyer,
awrichar and
peterbroadhurst
as code owners
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
nguyer
reviewed
Dec 19, 2023
| Stack: &types.Stack{ | ||
| Name: "TestBesuProviderWithEthconnect", | ||
| Members: []*types.Organization{{OrgName: "Org1"}}, | ||
| BlockchainProvider: fftypes.FFEnumValue("BlockchainProvider", "EthConnect"), |
There was a problem hiding this comment.
Should this be EthConnect here? EthConnect is a BlockchainConnector not a BlockchainProvider
| Members: []*types.Organization{{OrgName: "Org1"}}, | ||
| BlockchainProvider: fftypes.FFEnumValue("BlockchainProvider", "EthConnect"), | ||
| BlockchainConnector: fftypes.FFEnumValue("BlockchainConnector", "EthConnect"), | ||
| BlockchainNodeProvider: fftypes.FFEnumValue("BlockchainNodeProvider", "EthConnect"), |
There was a problem hiding this comment.
Should this be EthConnect here? EthConnect is a BlockchainConnector not a BlockchainNodeProvider
| Stack: &types.Stack{ | ||
| Members: []*types.Organization{{OrgName: "Org2"}, {OrgName: "org4"}}, | ||
| Name: "TestBesuProviderWithEvmconnect", | ||
| BlockchainProvider: fftypes.FFEnumValue("BlockchainProvider", "Geth"), |
There was a problem hiding this comment.
Should this be Besu here? I don't think this test case is doing anything with Geth?
| Name: "TestBesuProviderWithEvmconnect", | ||
| BlockchainProvider: fftypes.FFEnumValue("BlockchainProvider", "Geth"), | ||
| BlockchainConnector: fftypes.FFEnumValue("BlockchainConnector", "EvmConnect"), | ||
| BlockchainNodeProvider: fftypes.FFEnumValue("BlockchainNodeProvider", "Geth"), |
There was a problem hiding this comment.
Should this be Besu here? I don't think this test case is doing anything with Geth?
There was a problem hiding this comment.
@nguyer thanks for pointing these out i have made adjustments to the testcases, and placed the appropriate values for each field
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
Philip-21
changed the title
Philip-21
changed the title
Philip-21
changed the title
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
Signed-off-by: Philip-21 <[email protected]>
|
@nguyer I have written some tests for the Blockchain Node providers, I made adjustments to the corrections you pointed out . |
|
Thanks! This looks great |
nguyer
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pr fixes for #7
@nguyer, @awrichar
New Unit tests have been written for the ethereum blockchain node providers, the Besu and geth in the Ethereum Blockchain.
These tests pass successfully