Properly handle expired identities in gossip (release-2.5) #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a peer's certificate expires, gossip still retains past messages it has sent, and gossips them to other peers. Aside from peers doing redundant work, this also impairs their connectivity to the peer with the renewed certificate. The reason is that peers try connect to the peer of the renewed certificate but abort because they cannot find its (old) PKI-ID in the identity store, which purged its old PKI-ID once its certificate has expired. This commit fixes this problem by making the peer forget about peers that their identities have been purged from the identity store. Signed-off-by: David Enyeart <[email protected]> Signed-off-by: Yacov Manevich <[email protected]>
yacovm
previously approved these changes
Jan 27, 2025
denyeart
force-pushed
the
gossip_rewnew_certs_25
branch
from
76a8649 to
d1fdf8d
Compare
The membership check via discovery does not work consistently due to the renewed cert signature not matching expectations. For now, it is sufficient to do the membership check via checking the log. Signed-off-by: David Enyeart <[email protected]>
denyeart
force-pushed
the
gossip_rewnew_certs_25
branch
from
d1fdf8d to
7854362
Compare
yacovm
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a peer's certificate expires, gossip still retains past messages it has sent, and gossips them to other peers.
Aside from peers doing redundant work, this also impairs their connectivity to the peer with the renewed certificate.
The reason is that peers try connect to the peer of the renewed certificate but abort because they cannot find its (old) PKI-ID in the identity store, which purged its old PKI-ID once its certificate has expired.
This commit fixes this problem by making the peer forget about peers that their identities have been purged from the identity store.