Skip to content

Commit

Permalink
Update gossip cert renewal integration test (#5123)
Browse files Browse the repository at this point in the history
Change timings to be consistent with release-2.5
and avoid flakes.

Signed-off-by: David Enyeart <[email protected]>
  • Loading branch information
denyeart authored Jan 27, 2025
1 parent 9b63d8a commit 7ba0024
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions integration/gossip/gossip_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -318,11 +318,8 @@ var _ = Describe("Gossip State Transfer and Membership", func() {
renewPeerCertificate(network, peer0Org2, time.Now().Add(time.Minute))
startPeers(nwprocs, false, peer0Org2)

By("ensuring that peer0Org1 replaces peer0Org2 PKI-ID")
peer0Org1Runner := nwprocs.peerRunners[peer0Org1.ID()]
Eventually(peer0Org1Runner.Err(), network.EventuallyTimeout).Should(gbytes.Say("changed its PKI-ID from"))

By("verifying membership after cert renewed")
peer0Org1Runner := nwprocs.peerRunners[peer0Org1.ID()]
Eventually(peer0Org1Runner.Err(), network.EventuallyTimeout).Should(gbytes.Say("Membership view has changed. peers went online"))
/*
// TODO - Replace membership log check with membership discovery check (not currently working since renewed cert signature doesn't always match expectations even though it is forced to be Low-S)
Expand All @@ -334,7 +331,7 @@ var _ = Describe("Gossip State Transfer and Membership", func() {
*/

By("waiting for cert to expire within a minute")
Eventually(peer0Org1Runner.Err(), network.EventuallyTimeout).Should(gbytes.Say("gossipping peer identity expired"))
Eventually(peer0Org1Runner.Err(), time.Minute*2).Should(gbytes.Say("gossipping peer identity expired"))

By("stopping, renewing peer0Org2 certificate again after its expiration, restarting")
stopPeers(nwprocs, peer0Org2)
Expand Down

0 comments on commit 7ba0024

Please sign in to comment.