Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add write batch to state #243

Merged
merged 1 commit into from
Jan 8, 2025
Merged

add write batch to state #243

merged 1 commit into from
Jan 8, 2025

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Dec 3, 2024 •
edited
Loading

jt-nti
jt-nti reviewed Dec 4, 2024
View reviewed changes
bindings/go-apiv1/.gitignore Outdated Show resolved Hide resolved
bindings/go-apiv2/.gitignore Outdated Show resolved Hide resolved
@pfi79
add change state batch
cd2461b 
Signed-off-by: Fedor Partanskiy <[email protected]>
@pfi79 pfi79 force-pushed the batch-operation-p branch from cb116d3 to cd2461b Compare December 4, 2024 19:41
@denyeart
Copy link
Contributor

denyeart commented Dec 4, 2024

Thanks @pfi79 , note that we still need the final updates in the RFC per hyperledger/fabric-rfcs#58 before we do final review and merge of this one.

@pfi79
Copy link
Contributor Author

pfi79 commented Dec 4, 2024

Thanks @pfi79 , note that we still need the final updates in the RFC per hyperledger/fabric-rfcs#58 before we do final review and merge of this one.

Totally agree with you, so I did as draft. If there are any cancellations or changes, I will close or redo it.

@pfi79 pfi79 marked this pull request as ready for review December 22, 2024 08:54
@pfi79 pfi79 requested a review from a team as a code owner December 22, 2024 08:54
@pfi79
Copy link
Contributor Author

pfi79 commented Dec 23, 2024

@denyeart @C0rWin @satota2 @yacovm

denyeart
denyeart approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfi79 Sorry for the delay, just getting back from the holiday... this looks good to me.

I'm assuming @C0rWin as the RFC author would also like to review the PRs...

@C0rWin
Copy link

C0rWin commented Jan 8, 2025

@pfi79 Sorry for the delay, just getting back from the holiday... this looks good to me.

I'm assuming @C0rWin as the RFC author would also like to review the PRs...

Pretty straightforward, thanks @pfi79 LGTM.

@C0rWin C0rWin merged commit 4af0c57 into hyperledger:main Jan 8, 2025
20 checks passed
@pfi79 pfi79 deleted the batch-operation-p branch January 8, 2025 14:04
@pfi79
Copy link
Contributor Author

pfi79 commented Jan 8, 2025 •
edited
Loading

@denyeart @bestbeforetoday @jt-nti please put a new tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyeart denyeart denyeart approved these changes

@C0rWin C0rWin C0rWin approved these changes

@jt-nti jt-nti Awaiting requested review from jt-nti

@bestbeforetoday bestbeforetoday Awaiting requested review from bestbeforetoday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pfi79 @denyeart @C0rWin @jt-nti @bestbeforetoday