Merge code from master branch to android branch

[void-main]

I managed to merge code from master to android branch and changed the version to 3.4.0-android.

I really need this merge to make MnemonicUtils work on android.

[conor10]

@void-main I presume you've seen the build isn't working?

[void-main]

@conor10 yes, working on that

[codecov]

Codecov Report

Merging #626 into android will increase coverage by 0.29%.
The diff coverage is 78.9%.

@@              Coverage Diff              @@
##             android     #626      +/-   ##
=============================================
+ Coverage      75.91%   76.21%   +0.29%     
- Complexity      1604     1769     +165     
=============================================
  Files            209      240      +31     
  Lines           6170     6768     +598     
  Branches         980     1016      +36     
=============================================
+ Hits            4684     5158     +474     
- Misses          1256     1365     +109     
- Partials         230      245      +15

Impacted Files	Coverage Δ	Complexity Δ
...rity/methods/response/ParityAddressesResponse.java	100% <ø> (ø)	2 <0> (ø)	⬇️
crypto/src/main/java/org/web3j/crypto/Wallet.java	75.23% <ø> (-0.24%)	13 <0> (ø)
...rc/main/java/org/web3j/protocol/core/Response.java	95.83% <ø> (ø)	11 <0> (ø)	⬇️
...src/main/java/org/web3j/crypto/RawTransaction.java	89.47% <ø> (ø)	10 <0> (ø)	⬇️
core/src/main/java/org/web3j/ens/EnsResolver.java	67.24% <ø> (ø)	14 <0> (ø)	⬇️
...c/main/java/org/web3j/protocol/core/RpcErrors.java	0% <0%> (ø)	0 <0> (?)
...ocol/core/methods/response/MinerStartResponse.java	0% <0%> (ø)	0 <0> (?)
.../protocol/websocket/events/SyncingNotfication.java	0% <0%> (ø)	0 <0> (?)
...java/org/web3j/protocol/admin/JsonRpc2_0Admin.java	88.88% <0%> (-11.12%)	7 <0> (ø)
.../src/main/java/org/web3j/protocol/admin/Admin.java	0% <0%> (ø)	0 <0> (?)
... and 92 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a007536...ad25e75. Read the comment docs.

[void-main]

@conor10 fixed the failed test cases.

[conor10]

@void-main Have you tried building on the command line with Gradle? There's Java 8 specific code in the merge (search for -> in the diffs) which will break the backward compatibility.

[void-main]

@conor10 I tried to build with gradlew build and it actually passed.. But I did see some -> in diff files, I'll take a look.

[conor10]

When I run the build myself locally it fails:

$ ./gradlew clean check
Starting a Gradle Daemon (subsequent builds will be faster)
Support for running Gradle using Java 7 has been deprecated and is scheduled to be removed in Gradle 5.0. Please see https://docs.gradle.org/4.3/userguide/java_plugin.html#sec:java_cross_compilation for more details.

> Task :abi:compileJava FAILED
/Users/Conor/code/java/web3j-android/abi/src/main/java/org/web3j/abi/datatypes/Event.java:32: error: ')' expected
                .filter(TypeReference::isIndexed)
                                     ^
/Users/Conor/code/java/web3j-android/abi/src/main/java/org/web3j/abi/datatypes/Event.java:32: error: illegal start of expression
                .filter(TypeReference::isIndexed)
                                      ^
/Users/Conor/code/java/web3j-android/abi/src/main/java/org/web3j/abi/datatypes/Event.java:32: error: ';' expected
                .filter(TypeReference::isIndexed)
                                                ^
/Users/Conor/code/java/web3j-android/abi/src/main/java/org/web3j/abi/datatypes/Event.java:38: error: illegal start of expression
                .filter(p -> !p.isIndexed())
                           ^
4 errors

[void-main]

@conor10 Oh, boy, the websocket package is a mess, I have to replace every CompletableFuture with Future, I mean, kind of a re-write thing, gonna need some time..

[conor10]

No problem - your work is much appreciated.

[snazha-blkio]

This will be addressed in #769, closing this PR.