Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix egoistic funding #414

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

sophia1ch
Copy link
Contributor

This PR extends #410 and fixes parallel egoistic payment channels, where on participant funds last.
Previously the egoistic funding implementation was not suitable for parallel applications. This is fixed by enabling egoistic participants instead of egoistic chains.

feat(Asset, Adjudicator): Add AssetID struct to identify assets with LedgerID and BackendID
feat(persistence, wire): Use map[int]Address to identify clients

Signed-off-by: Sophia Koehler <[email protected]>
…and adjudicators.

fix(randomizer): Lookup backend opts to correctly initialize address maps.
fix(test): Generalize tests to be used in other backends.

Signed-off-by: Sophia Koehler <[email protected]>
Signed-off-by: Sophia Koehler <[email protected]>
fix(wallet/wallet, wallet/account): Revert changed definition.
feat(client): Add wallet map to client for each backend.

Signed-off-by: Sophia Koehler <[email protected]>
feat(client/test, wire): Add backendID arguments.

Signed-off-by: Sophia Koehler <[email protected]>
…t, ): Specify backend for randomizers

feat(channel/multi): Change AssetID to interface
feat(channel/persistence, client/test): Generalize test for backends

Signed-off-by: Sophia Koehler <[email protected]>
…ad of string.

fix(params.go): Change IDKey to encode map entries sorted by keys.
fix(backend.go): Use BackendID in argument to sign depending on backend.
fix(address.go): Sort Addresses by keys before adding them to Keys.

Signed-off-by: Sophia Koehler <[email protected]>
Signed-off-by: Sophia Koehler <[email protected]>
…n of errors

chore(All): Run gofmt and sort imports

Signed-off-by: Sophia Koehler <[email protected]>
chore: Refactor for linter

Signed-off-by: Sophia Koehler <[email protected]>
fix(golangci): Fix structure

Signed-off-by: Sophia Koehler <[email protected]>
Signed-off-by: Sophia Koehler <[email protected]>
… index instead of chain and remove unnecessary functions.

Signed-off-by: Sophia Koehler <[email protected]>
@sophia1ch sophia1ch marked this pull request as draft January 14, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant