Skip to content

Commit

Permalink
refactoring
Browse files Browse the repository at this point in the history
Signed-off-by: Angelo De Caro <[email protected]>
  • Loading branch information
adecaro committed Feb 1, 2025
1 parent dbcc8da commit 79427fb
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 16 deletions.
10 changes: 0 additions & 10 deletions token/driver/publicparams.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ SPDX-License-Identifier: Apache-2.0

package driver

import (
"github.com/hyperledger-labs/fabric-smart-client/platform/common/driver"
)

// PPHash is used to model the hash of the raw public parameters.
// This should avoid confusion between the bytes of the public params themselves and its hash.
type PPHash []byte
Expand All @@ -30,12 +26,6 @@ func (pp *SerializedPublicParameters) Deserialize(raw []byte) error {
return nil
}

// NetworkPublicParamsFetcher models a public parameters fetcher per network.
type NetworkPublicParamsFetcher interface {
// Fetch fetches the public parameters for the given network, channel, and namespace
Fetch(network driver.Network, channel driver.Channel, namespace driver.Namespace) ([]byte, error)
}

// PublicParamsFetcher models a public parameters fetcher.
type PublicParamsFetcher interface {
// Fetch fetches the public parameters from a repository.
Expand Down
12 changes: 9 additions & 3 deletions token/services/network/fabric/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ package fabric
import (
"slices"

driver4 "github.com/hyperledger-labs/fabric-smart-client/platform/common/driver"
"github.com/hyperledger-labs/fabric-smart-client/platform/fabric"
config2 "github.com/hyperledger-labs/fabric-smart-client/platform/fabric/core/generic/config"
"github.com/hyperledger-labs/fabric-smart-client/platform/view"
driver2 "github.com/hyperledger-labs/fabric-smart-client/platform/view/driver"
"github.com/hyperledger-labs/fabric-token-sdk/token"
driver3 "github.com/hyperledger-labs/fabric-token-sdk/token/driver"
vault2 "github.com/hyperledger-labs/fabric-token-sdk/token/sdk/vault"
"github.com/hyperledger-labs/fabric-token-sdk/token/services/config"
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network/common"
Expand All @@ -30,6 +30,12 @@ import (
"go.opentelemetry.io/otel/trace"
)

// NetworkPublicParamsFetcher models a public parameters fetcher per network.
type NetworkPublicParamsFetcher interface {
// Fetch fetches the public parameters for the given network, channel, and namespace
Fetch(network driver4.Network, channel driver4.Channel, namespace driver4.Namespace) ([]byte, error)
}

type Driver struct {
fnsProvider *fabric.NetworkServiceProvider
vaultProvider driver.TokenVaultProvider
Expand All @@ -41,7 +47,7 @@ type Driver struct {
tmsProvider *token.ManagementServiceProvider
identityProvider driver2.IdentityProvider
tracerProvider trace.TracerProvider
defaultPublicParamsFetcher driver3.NetworkPublicParamsFetcher
defaultPublicParamsFetcher NetworkPublicParamsFetcher
tokenQueryExecutorProvider driver.TokenQueryExecutorProvider
spentTokenQueryExecutorProvider driver.SpentTokenQueryExecutorProvider
supportedDrivers []string
Expand Down Expand Up @@ -98,7 +104,7 @@ func NewDriver(
tmsProvider *token.ManagementServiceProvider,
tracerProvider trace.TracerProvider,
identityProvider driver2.IdentityProvider,
defaultPublicParamsFetcher driver3.NetworkPublicParamsFetcher,
defaultPublicParamsFetcher NetworkPublicParamsFetcher,
tokenQueryExecutorProvider driver.TokenQueryExecutorProvider,
spentTokenQueryExecutorProvider driver.SpentTokenQueryExecutorProvider,
keyTranslator translator.KeyTranslator,
Expand Down
5 changes: 2 additions & 3 deletions token/services/network/fabric/network.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/tracing"
"github.com/hyperledger-labs/fabric-smart-client/platform/view/view"
token2 "github.com/hyperledger-labs/fabric-token-sdk/token"
driver3 "github.com/hyperledger-labs/fabric-token-sdk/token/driver"
"github.com/hyperledger-labs/fabric-token-sdk/token/services/logging"
common2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/network/common"
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network/common/rws/translator"
Expand Down Expand Up @@ -115,7 +114,7 @@ type Network struct {
tokenVaultLazyCache lazy.Provider[string, driver.TokenVault]
flm finality.ListenerManager
llm lookup.ListenerManager
defaultPublicParamsFetcher driver3.NetworkPublicParamsFetcher
defaultPublicParamsFetcher NetworkPublicParamsFetcher
tokenQueryExecutor driver.TokenQueryExecutor
spentTokenQueryExecutor driver.SpentTokenQueryExecutor
endorsementServiceProvider EndorsementServiceProvider
Expand All @@ -134,7 +133,7 @@ func NewNetwork(
endorsementServiceProvider EndorsementServiceProvider,
tokenQueryExecutor driver.TokenQueryExecutor,
tracerProvider trace.TracerProvider,
defaultPublicParamsFetcher driver3.NetworkPublicParamsFetcher,
defaultPublicParamsFetcher NetworkPublicParamsFetcher,
spentTokenQueryExecutor driver.SpentTokenQueryExecutor,
keyTranslator translator.KeyTranslator,
flm finality.ListenerManager,
Expand Down

0 comments on commit 79427fb

Please sign in to comment.