-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3240: Guard against secrets leakage #4457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing and
Asem-Abdelhady
as code owners
April 17, 2024 11:09
Erigara
reviewed
Apr 17, 2024
dima74
force-pushed
the
guard-private-key
branch
from
April 17, 2024 12:52
ae088ba
to
4328892
Compare
DCNick3
reviewed
Apr 17, 2024
dima74
force-pushed
the
guard-private-key
branch
from
April 17, 2024 13:57
4328892
to
23b0ed9
Compare
DCNick3
approved these changes
Apr 17, 2024
Erigara
approved these changes
Apr 17, 2024
mversic
force-pushed
the
guard-private-key
branch
from
April 17, 2024 16:50
23b0ed9
to
b7f3aa3
Compare
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Apr 17, 2024
I was thinking that this change won't affect iroha_crypto crate. IMO This should be an external functionality and not integrated into iroha_crypto, the change should be in iroha_config mostly |
To summarize today discussion:
The plan is to merge current implementation as-is if no new concerns arise |
mversic
force-pushed
the
guard-private-key
branch
from
April 18, 2024 13:29
b7f3aa3
to
9082e5f
Compare
Signed-off-by: Dmitry Murzin <[email protected]>
mversic
force-pushed
the
guard-private-key
branch
from
April 18, 2024 14:33
9082e5f
to
082fb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Secret
toPrivateKey
. Access to innerPrivateKeyInner
now requires import ofExposeSecret
trait viaexpose_secret
methodDisplay
,Debug
andSerialize
implementations forPrivateKey
now returns"[REDACTED]"
ExposedPrivateKey
wrapper which can be formatted and serialized as usualsecrecy
crate because it requires to implementZeroize
trait, but inner key struct (ed25519_dalek::SigningKey
) implement onlyZeroizeOnDrop
, and notZeroize
. So I used modified version ofSecret
which requiresZeroizeOnDrop
instead ofZeroize
. This potentially could be controversal, so any suggestions are welcomeLinked issue
Closes #3240
Checklist
CONTRIBUTING.md