-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci]: Fix auto-labeling #4276
[ci]: Fix auto-labeling #4276
Conversation
Can we wait with merging of this until the merge of #4239? That PR changes the approach to the config itself. Actually, after the 2.0 release there should NOT be breaking changes in the config and we should establish a clear deprecation and migration policy. |
From my side, it would be better to be notified via PR auto-assignment or just auto-comment with my username because it's better rather than to search for PRs with
But I understand that we should'n bind CI within any particular person. |
2f6204a
to
4c8c6e3
Compare
Pull Request Test Coverage Report for Build 7987011957Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Yeah, for now this PR is only intended to add clues to detect configuration changes.
But before that, we have yet to see CI label |
We will think about it later. I want say that we should try to avoid creating a new workflows for tiny tasks whatever it's possible. |
4c8c6e3
to
cd12942
Compare
config-changes
the role of an automatic label againThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR itself cannot trigger the changed workflows since pull_request_target
event-driven workflows are based on the code of the base branch (hyperledger:iroha2-dev
)
https://github.com/actions/labeler?tab=readme-ov-file#initial-set-up-of-the-labeler-action
cd12942
to
b688b2f
Compare
b688b2f
to
7654a2f
Compare
7654a2f
to
7a511f5
Compare
Signed-off-by: Shunkichi Sato <[email protected]>
7a511f5
to
6c21f53
Compare
Description
api-changes
config-changes
auto-labelingiroha2
into one workflowLinked issue
Benefits
Checklist
CONTRIBUTING.md