Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds in-memory and Redis as session stores #14

Merged
merged 3 commits into from
Jul 15, 2024
Merged

feat: adds in-memory and Redis as session stores #14

merged 3 commits into from
Jul 15, 2024

Conversation

kevinhermawan
Copy link
Contributor

@kevinhermawan kevinhermawan commented Jul 11, 2024 •
edited
Loading

Things need to test

  • Session management when using in-memory
  • Session management when using redis
  • Docker compose

raosan
raosan reviewed Jul 11, 2024
View reviewed changes
services/session.ts Outdated Show resolved Hide resolved
raosan
raosan requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@raosan raosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to remove unstorage and use varieble for in-memory

@raosan raosan merged commit 098e6b3 into main Jul 15, 2024
2 checks passed
@raosan raosan deleted the feat/session branch July 15, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raosan raosan raosan approved these changes

@sapiderman sapiderman Awaiting requested review from sapiderman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinhermawan @raosan @kevin-hyperjump