Clean up warnings (#237)

* Address warning for unused field

* Apply suggestions from clippy

* Set resolver = 2 for the workspace

Cargo.toml

@@ -7,3 +7,4 @@ members = [
     # Internal
     "examples",
 ]
+resolver = "2"

h3/src/qpack/dynamic.rs

@@ -667,7 +667,7 @@ mod tests {
 
         assert_eq!(table.fields.len(), 1);
         assert_eq!(
-            table.fields.get(0),
+            table.fields.front(),
             Some(&HeaderField::new("Name-Large", "Value-Large"))
         );
     }
@@ -736,7 +736,7 @@ mod tests {
         insert_fields(&mut table, vec![HeaderField::new("Name-C", "Value-C")]);
 
         assert_eq!(
-            table.fields.get(0),
+            table.fields.front(),
             Some(&HeaderField::new("Name-B", "Value-B"))
         );
         assert_eq!(
@@ -1042,7 +1042,7 @@ mod tests {
             assert_eq!(table.track_map.get(&1), Some(&1));
         }
         let track_blocks = table.track_blocks;
-        let block = track_blocks.get(&stream_id).unwrap().get(0).unwrap();
+        let block = track_blocks.get(&stream_id).unwrap().front().unwrap();
         assert_eq!(block.get(&1), Some(&1));
         assert_eq!(block.get(&2), Some(&1));
         assert_eq!(block.get(&3), Some(&1));

h3/src/qpack/tests.rs

@@ -46,7 +46,7 @@ fn codec_basic_get() {
     ];
 
     encoder
-        .encode(42, &mut block_buf, &mut enc_buf, header.clone().into_iter())
+        .encode(42, &mut block_buf, &mut enc_buf, header.clone())
         .unwrap();
 
     let mut enc_cur = Cursor::new(&mut enc_buf);
@@ -113,7 +113,7 @@ fn codec_table_size_0() {
     let mut decoder = Decoder::from(dec_table);
 
     encoder
-        .encode(42, &mut block_buf, &mut enc_buf, header.clone().into_iter())
+        .encode(42, &mut block_buf, &mut enc_buf, header.clone())
         .unwrap();
 
     let mut enc_cur = Cursor::new(&mut enc_buf);
@@ -148,7 +148,7 @@ fn codec_table_full() {
     let mut decoder = Decoder::from(dec_table);
 
     encoder
-        .encode(42, &mut block_buf, &mut enc_buf, header.clone().into_iter())
+        .encode(42, &mut block_buf, &mut enc_buf, header.clone())
         .unwrap();
 
     let mut enc_cur = Cursor::new(&mut enc_buf);

h3/src/stream.rs

@@ -250,7 +250,7 @@ where
     B: Buf,
 {
     Control(FrameStream<S, B>),
-    Push(u64, FrameStream<S, B>),
+    Push(FrameStream<S, B>),
     Encoder(BufRecvStream<S, B>),
     Decoder(BufRecvStream<S, B>),
     WebTransportUni(SessionId, BufRecvStream<S, B>),
@@ -283,10 +283,7 @@ where
     pub fn into_stream(self) -> Result<AcceptedRecvStream<S, B>, Error> {
         Ok(match self.ty.expect("Stream type not resolved yet") {
             StreamType::CONTROL => AcceptedRecvStream::Control(FrameStream::new(self.stream)),
-            StreamType::PUSH => AcceptedRecvStream::Push(
-                self.id.expect("Push ID not resolved yet").into_inner(),
-                FrameStream::new(self.stream),
-            ),
+            StreamType::PUSH => AcceptedRecvStream::Push(FrameStream::new(self.stream)),
             StreamType::ENCODER => AcceptedRecvStream::Encoder(self.stream),
             StreamType::DECODER => AcceptedRecvStream::Decoder(self.stream),
             StreamType::WEBTRANSPORT_UNI => AcceptedRecvStream::WebTransportUni(

h3/src/tests/connection.rs

@@ -109,8 +109,7 @@ async fn server_send_data_without_finish() {
             .await
             .unwrap();
         let data = vec![0; 100];
-        let _ = req
-            .send_data(bytes::Bytes::copy_from_slice(&data))
+        req.send_data(bytes::Bytes::copy_from_slice(&data))
             .await
             .unwrap();
         let _ = req.recv_response().await.unwrap();