Fix: remove tracked download resources to avoid erroneous double-releases #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my ctzn tests, I had remote hyperbees throw the following error during a hypercore
.close()
:I tracked this down to the
deleteResource()
calls which were releasing active downloads. Turns out completed downloads were not being removed from the set of tracked download-resources, leading to this error due to a double-release.The PR fixes this by removing a completed download from the set.