Skip to content

Commit

Permalink
Update from hummingbird-project-template e0591c10226828f2039482563cf3…
Browse files Browse the repository at this point in the history
…3b0f3f1eea80
  • Loading branch information
adam-fowler authored Jun 28, 2024
1 parent 540a1b8 commit c86b3de
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ updates:
directory: "/"
schedule:
interval: "daily"
open-pull-requests-limit: 6
open-pull-requests-limit: 5
allow:
- dependency-type: all
groups:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/api-breakage.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# This will be interesting to see how often AWS break there own APIs
name: API breaking changes

on:
Expand All @@ -9,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
container:
image: swift:5.9
image: swift:5.10
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
image: ["swift:5.9", "swift:5.10", "swiftlang/swift:nightly-jammy"]
image: ["swift:5.9", "swift:5.10", "swiftlang/swift:nightly-6.0-jammy"]

container:
image: ${{ matrix.image }}
Expand Down
2 changes: 1 addition & 1 deletion .swiftformat
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
--exclude .build

# rules
--disable redundantReturn, extensionAccessControl, typeSugar
--disable redundantReturn, extensionAccessControl, typeSugar, conditionalAssignment

# format options
--ifdef no-indent
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Please ensure to include the following in your Pull Request
- Documentation on how these changes are being tested
- Additional tests to show your code working and to ensure future changes don't break your code.

Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a large change to a module (or bringing in a new dependency) please consider making these changes in a separate repository. The idea is that Hummingbird/HummingbirdCore are kept as slimline as possible. These concerns can be discussed in a Github Issue.

Please keep your PRs to a minimal number of changes. If a PR is large try to split it up into smaller PRs. Don't move code around unnecessarily it makes comparing old with new very hard.

The main development branch of the repository is `main`.
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ================================
# Build image
# ================================
FROM swift:5.9 as build
FROM swift:5.10 as build

WORKDIR /build

Expand All @@ -15,4 +15,4 @@ RUN swift package resolve
# Copy entire repo into container
COPY . .

RUN swift test --enable-test-discovery --sanitize=thread
RUN swift test --sanitize=thread

0 comments on commit c86b3de

Please sign in to comment.