[Reputation Oracle] NDA #3132
Open
[Reputation Oracle] NDA #3132
+574
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
@flopez7 please, rebase develop branch to resolve conflicts. |
dnechay
reviewed
Feb 28, 2025
packages/apps/reputation-oracle/server/src/modules/nda/nda.module.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/nda/nda.controller.ts
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/nda/nda.controller.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/nda/nda.controller.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/nda/nda.service.spec.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/nda/nda.service.spec.ts
Outdated
Show resolved
Hide resolved
Dzeranov
reviewed
Mar 3, 2025
packages/apps/reputation-oracle/server/src/modules/nda/nda.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/reputation-oracle/server/src/modules/user/user.entity.ts
Outdated
Show resolved
Hide resolved
portuu3
requested changes
Mar 4, 2025
packages/apps/reputation-oracle/server/src/modules/nda/nda.service.spec.ts
Outdated
Show resolved
Hide resolved
portuu3
previously approved these changes
Mar 4, 2025
* feat: add NDA module with service, controller, and related functionality * feat: add HTTP status code to signNDA endpoint and update tests to use ndaServiceMock * Move user within the signNDA tests as it is not being modified
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/apps/human-app/server/src/modules/nda/spec/nda.fixtures.ts
Dismissed
Show dismissed
Hide dismissed
portuu3
previously approved these changes
Mar 4, 2025
portuu3
reviewed
Mar 4, 2025
|
@portuu3 I think that it should be done together with the frontend implementation. However, we can implement this with a feature flag on human app server. |
dnechay
approved these changes
Mar 4, 2025
|
|
||
| describe('signNDA', () => { | ||
| let user: Pick<UserEntity, 'id' | 'email' | 'ndaSignedUrl'>; | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
Suggested change
| beforeEach(async () => { | |
| beforeEach(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
#3105
Context behind the change
add NDA module and related functionality
How has this been tested?
Launched locally.
Created one new user.
Signed the NDA
Release plan
Add
NDA_URLin Reputation Oracle environmentPotential risks; What to monitor; Rollback plan
None