Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump node to 22 w/ dep updates #3103

Merged
merged 12 commits into from
Feb 21, 2025
Merged

deps: bump node to 22 w/ dep updates #3103

merged 12 commits into from
Feb 21, 2025

Conversation

dnechay
Copy link
Contributor

@dnechay dnechay commented Feb 19, 2025

Issue tracking

N/A

Context behind the change

We got an error from "Dependency Review" check about parse-duration package vulnerability. In order to fix that we can't just use resolutions because fix is in major version, so we need to bump parent package - @graphprotocol/graph-cli - and that requires to use Node@20

Taking into account that Node@18 is not LTS anymore starting April 2025, decided to switch to current LTS - 22.

Also in scope of this PR fixed other resolutions to use proper versions of packages in lock file: previously we were skipping some major release for fixes, which is not correct and might have implicit issues.

How has this been tested?

  • CI actions
  • changed NODE_VERSION for staging services on Render and rebuild + deploy, make sure they keep working fine
  • run scripts/cvat docker setup locally, make sure it's working e2e

Release plan

  • Update NODE_VERSION on Render Staging
  • Update Node.js version in Vercel to 22
  • Update NODE_VERSION on Render Production
  • Update references on Node version in docs

Potential risks; What to monitor; Rollback plan

That something is missing in release plan for specific env. We should notice it during the build phase since we have packages that require Node@20 now so yarn install will fail if invalid Node version provided. As a solution - provide the correct one

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 3:42pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 3:42pm
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 3:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 3:42pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 3:42pm

@dnechay dnechay requested a review from portuu3 February 19, 2025 15:56
Copy link
Contributor

@Dzeranov Dzeranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@portuu3 please take a look.

@dnechay dnechay merged commit 1a8b7ce into develop Feb 21, 2025
24 checks passed
@dnechay dnechay deleted the dnechay/fix-deps branch February 21, 2025 09:55
This was referenced Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants