Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance refactor #3069

Merged
merged 19 commits into from
Feb 14, 2025
Merged

Balance refactor #3069

merged 19 commits into from
Feb 14, 2025

Conversation

portuu3
Copy link
Collaborator

@portuu3 portuu3 commented Feb 4, 2025 •
edited
Loading

Issue tracking

Closes #2982

Context behind the change

  • Fixes possible negative balances
  • Allows to choose the token for funding the escrow.
  • Use utils for handling operations like mul, div, etc

How has this been tested?

  • Created a job paid with fiat USD and funded with HMT
  • Created a job paid with HMT and funded with HMT
  • Funded the account with crypto
  • Funded the account with fiat
  • Refund after cancellation
  • Created a job using balance

Unit tests partially updated. Job service needs a refactor so tests for this service will be implemented from scratch.

Release plan

Includes a migration to add token to jobs table

Potential risks; What to monitor; Rollback plan

Monitor payments table
Rollback: undo last migration

@portuu3 portuu3 self-assigned this Feb 4, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:55pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:55pm
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 2:55pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 2:55pm

@portuu3 portuu3 added the do-not-merge PR shouldn't be merged until this label is removed label Feb 4, 2025
@Dzeranov Dzeranov self-requested a review February 7, 2025 14:35
Dzeranov
Dzeranov reviewed Feb 7, 2025
View reviewed changes
@portuu3 portuu3 requested a review from Dzeranov February 13, 2025 10:14
Dzeranov
Dzeranov approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Dzeranov Dzeranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets release these changes as a separate release.

@portuu3 portuu3 added do-not-merge PR shouldn't be merged until this label is removed and removed do-not-merge PR shouldn't be merged until this label is removed labels Feb 13, 2025
@portuu3 portuu3 merged commit 69ff9a4 into develop Feb 14, 2025
15 checks passed
@portuu3 portuu3 deleted the jl/balance-refactor branch February 14, 2025 12:36
@portuu3 portuu3 mentioned this pull request Feb 14, 2025
Merged
16 tasks
@Dzeranov Dzeranov removed the do-not-merge PR shouldn't be merged until this label is removed label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzeranov Dzeranov Dzeranov approved these changes

Assignees

@portuu3 portuu3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Job Launcher] Payments refactor
3 participants
@portuu3 @Dzeranov @flopez7