Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confirm from ValidatePasswordDto #1516

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

flopez7
Copy link
Contributor

@flopez7 flopez7 commented Jan 23, 2024

Description

Remove confirm from ValidatePasswordDto and verify that the validation is being done in the frontend

Summary of changes

Remove confirm from ValidatePasswordDto
Remove confirm field sent in Job Launcher Client

How test the changes

yarn test

Related issues

#1496

@flopez7 flopez7 requested a review from portuu3 January 23, 2024 16:32
@flopez7 flopez7 self-assigned this Jan 23, 2024
Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:37pm
job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:37pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Jan 23, 2024 4:37pm
faucet-server ⬜️ Ignored (Inspect) Jan 23, 2024 4:37pm
reputation-oracle-server ⬜️ Ignored (Inspect) Jan 23, 2024 4:37pm

@portuu3 portuu3 merged commit 39e9b12 into develop Jan 24, 2024
16 checks passed
@portuu3 portuu3 deleted the feat/job-launcher/remove-confirm branch January 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants