Remove confirm from ValidatePasswordDto

humanprotocol · Jan 23, 2024 · 7688917 · 7688917
1 parent 260b73e
commit 7688917
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 83 deletions.
diff --git a/packages/apps/job-launcher/client/src/components/Auth/ResetPasswordForm.jsx b/packages/apps/job-launcher/client/src/components/Auth/ResetPasswordForm.jsx
@@ -22,12 +22,11 @@ export const ResetPasswordForm = () => {
   const navigate = useNavigate();
   const token = new URLSearchParams(window.location.search).get('token');
 
-  const handleResetPassword = async ({ password, repeatPassword }) => {
+  const handleResetPassword = async ({ password }) => {
     setIsLoading(true);
     try {
       await authService.resetPassword({
         password,
-        confirm: repeatPassword,
         token,
       });
 

diff --git a/packages/apps/job-launcher/client/src/components/Auth/SignUpForm.jsx b/packages/apps/job-launcher/client/src/components/Auth/SignUpForm.jsx
@@ -24,10 +24,10 @@ export const SignUpForm = ({ onFinish, onError }) => {
   const [email, setEmail] = useState('');
   const [alertMsg, setAlertMsg] = useState('');
 
-  const handleRegister = async ({ email, password, confirm }) => {
+  const handleRegister = async ({ email, password }) => {
     setIsLoading(true);
     try {
-      await authService.signUp({ email, password, confirm });
+      await authService.signUp({ email, password });
       setEmail(email);
       setIsSuccess(true);
     } catch (err) {

diff --git a/packages/apps/job-launcher/client/src/types/index.ts b/packages/apps/job-launcher/client/src/types/index.ts
@@ -8,7 +8,6 @@ export type SignInRequest = {
 export type SignUpRequest = {
   email: string;
   password: string;
-  confirm: string;
 };
 
 export type SignUpResponse = {
@@ -18,7 +17,6 @@ export type SignUpResponse = {
 
 export type ResetPasswordRequest = {
   password: string;
-  confirm: string;
   token: string;
 };
 

diff --git a/packages/apps/job-launcher/server/src/common/validators/confirm.ts b/packages/apps/job-launcher/server/src/common/validators/confirm.ts
diff --git a/packages/apps/job-launcher/server/src/common/validators/index.ts b/packages/apps/job-launcher/server/src/common/validators/index.ts
@@ -1,2 +1 @@
 export * from './password';
-export * from './confirm';
diff --git a/packages/apps/job-launcher/server/src/modules/auth/auth.dto.ts b/packages/apps/job-launcher/server/src/modules/auth/auth.dto.ts
@@ -1,7 +1,7 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { Transform } from 'class-transformer';
 import { IsEmail, IsString } from 'class-validator';
-import { IsConfirm, IsPassword } from '../../common/validators';
+import { IsPassword } from '../../common/validators';
 import { TokenType } from '../auth/token.entity';
 import { UserEntity } from '../user/user.entity';
 
@@ -27,10 +27,6 @@ export class ValidatePasswordDto {
   @ApiProperty()
   @IsPassword()
   public password: string;
-
-  @ApiProperty()
-  @IsConfirm()
-  public confirm: string;
 }
 
 export class ResendEmailVerificationDto {

diff --git a/packages/apps/job-launcher/server/src/modules/auth/auth.service.spec.ts b/packages/apps/job-launcher/server/src/modules/auth/auth.service.spec.ts
@@ -469,7 +469,6 @@ describe('AuthService', () => {
         authService.restorePassword({
           token: 'token',
           password: 'password',
-          confirm: 'password',
         }),
       ).rejects.toThrow(NotFoundException);
     });
@@ -485,7 +484,6 @@ describe('AuthService', () => {
       await authService.restorePassword({
         token: 'token',
         password: 'password',
-        confirm: 'password',
       });
 
       expect(updatePasswordMock).toHaveBeenCalled();

diff --git a/packages/apps/job-launcher/server/src/modules/user/user.service.spec.ts b/packages/apps/job-launcher/server/src/modules/user/user.service.spec.ts
@@ -70,7 +70,6 @@ describe('UserService', () => {
       const dto: UserCreateDto = {
         email: '[email protected]',
         password: 'password123',
-        confirm: 'password123',
       };
       const hashedPassword =
         '$2b$12$Z02o9/Ay7CT0n99icApZYORH8iJI9VGtl3mju7d0c4SdDDujhSzOa';
@@ -102,7 +101,6 @@ describe('UserService', () => {
       const dto: UserCreateDto = {
         email: '[email protected]',
         password: 'password123',
-        confirm: 'password123',
       };
 
       jest
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		export * from './password';
		export * from './confirm';