-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default theme #960
Added default theme #960
Conversation
✅ Deploy Preview for toha-ci ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @joyao! Thank you for the PR. It looks good. I was just wondering if we should combine the theme options under single configuration instead of splitting into I was thinking something like this: params:
features:
theme:
light: true # enable light theme. default "true"
dark: true # enable dark theme. default "true"
defaultTheme: light # can be either light, dark or system. default "system" What do you think? This will require more work but I can update your PR. We also have to keep backward compatibility. |
Hi @hossainemruz, that’s a good point and I agree with you. I can try to update if you're not in a hurry. Please let me know your thoughts. |
That would be great! Go ahead with the change. Just make sure we are not breaking existing sites. |
For sure. This is the unchanging rule. :) |
Hi @hossainemruz, features and comments have been updated based on what was discussed previously. Please check. |
Thank you @joyao! I will take a look whenever get some time. Thank you for the amazing work. |
Signed-off-by: hossainemruz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @joyao! Looks good now.
[Updated]
Issue
Add a new theme feature and fully resolved issues #931 and #934.
Description
As a developer, I want to be able to customize the theme of my website so that users can have a better browsing experience.
Changes:
Test Evidence
disable darkMode
enable darkMode
enable theme without service settings
disable theme settings
enable theme service default settings
enable theme settings & set light = false
enable theme settings & set dark = false
enable theme settings & set default = light
enable theme settings & set default = dark
enable theme settings
set light = false & set default = light
enable theme settings
set dark = false & set default = dark
enable theme settings