Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode image setting when system dark is used #923

Merged
merged 3 commits into from
May 10, 2024

Conversation

andrewmolyuk
Copy link
Contributor

Issue

Images do not switch to dark view when system dark is used in theme mode.

Description

Images do not switch to dark view when system dark is used in theme mode.

Test Evidence

  1. Change system theme to dark
  2. Be sure that Dark mode is enabled in config.yaml
  3. Add darkLogo to company item in experiences.yaml
  4. Run website
  5. Switch to system theme mode - it should be dark
  6. All images are not switched to their dark representation

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 5dd67cb
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/663e5e6272e0a70008dce92a
😎 Deploy Preview https://deploy-preview-923--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrewmolyuk

@hossainemruz hossainemruz merged commit 2b47657 into hugo-toha:main May 10, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants