Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param profile to hide author in post #870

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

BernatBC
Copy link
Member

@BernatBC BernatBC commented Jan 24, 2024

Issue

Hide author name and image in post? Fixes #867

Description

Added the possibility to hide author in post by setting the parameter:

profile: false #defaults true

I know this is not the most elegant solution (I had to add vertical gap).

Test Evidence

profile: true (or no profile set):
image

profile: false:
image

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit ec2d631
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/65bd1668fb34ac00089044ea
😎 Deploy Preview https://deploy-preview-870--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BernatBC BernatBC marked this pull request as draft January 24, 2024 10:10
@BernatBC
Copy link
Member Author

There's a bug that duplicates the date when profile is not set.

@BernatBC BernatBC marked this pull request as ready for review January 24, 2024 10:12
@BernatBC
Copy link
Member Author

Now the bug is fixed

@hossainemruz
Copy link
Member

Thank you @BernatBC! I think the configuration should go under params.features.blog. We can do something similar to this:

params:
  features:
    blog:
      showAuthor: false

@BernatBC
Copy link
Member Author

BernatBC commented Jan 24, 2024

Ok, I just changed the parameter location to:

params:
  features:
    blog:
      showAuthor: false

@hossainemruz
Copy link
Member

Thank you. I will test the changes specially on mobile device.

@dietervansteenwegen
Copy link
Contributor

Thank you. I will test the changes specially on mobile device.

Just to make sure I understand, you will test the changes on a mobile device because the 80 pixels spacing is hard-coded and thus not relative to the screen size/rendering? Or not?

@hossainemruz
Copy link
Member

Thank you. I will test the changes specially on mobile device.

Just to make sure I understand, you will test the changes on a mobile device because the 80 pixels spacing is hard-coded and thus not relative to the screen size/rendering? Or not?

Yes. I will check on mobile and Tablet.

@hossainemruz hossainemruz added enhancement New feature or request automerge labels Feb 2, 2024
@hossainemruz hossainemruz merged commit 3283a3b into hugo-toha:main Feb 2, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide author name and image in post?
3 participants