Add select maximum number of posts per page #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for toha-ci ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hossainemruz
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Thank you @BernatBC for the PR. Look like a reasonable feature to add. I just requested two small adjustments. Otherwise, the PR looks good.
hossainemruz
requested changes
Jan 19, 2024
|
I added it to the example site. |
|
I'll fix it now |
hossainemruz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
None, it's just a feature.
Description
With this parameter you can select the maximum number of posts that will appear to each page. It will default to 12 (the value that we were using before). To configure it, just add the following lines under the
paramssection ofconfig.yaml:Before I add this into the guides and the example file, tell me if you want to change the name of the parameter, or if I have to change the location of it.
Test Evidence
maxPostsPerPage=5
maxPostsPerPage=10