⚰️ Deprecate liger-kernel #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
requested review from
kashif,
lewtun and
edbeeching
and removed request for
kashif and
lewtun
qgallouedec
commented
Feb 24, 2025
trl/trainer/gkd_trainer.py
Outdated
Comment on lines
133
to
137
| elif hasattr(teacher_model, "get_base_model") and isinstance( | ||
| teacher_model.get_base_model(), PreTrainedModel | ||
| ): | ||
| # Patch the base model with liger kernels where model is a PeftModel. Use the default kernel configurations. | ||
| _apply_liger_kernel_to_instance(model=teacher_model.get_base_model()) |
There was a problem hiding this comment.
This is when teacher model is a peft model. Do we need it @kashif?
There was a problem hiding this comment.
i dont think we need it... as it is not supported currently... let me double check
…/trl into deprecated-use-liger
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
After this PR is merged, can I still pass a Liger model to |
|
Yes you can still pass a liger kernel model, but you will have to pas |
qgallouedec
commented
Feb 28, 2025
kashif
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #2940 (comment)