Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✂️ Truncate by default #2587

Merged
merged 4 commits into from
Jan 17, 2025
Merged

✂️ Truncate by default #2587

merged 4 commits into from
Jan 17, 2025

Conversation

qgallouedec
Copy link
Member

What does this PR do?

Not truncating by default is a bad idea as it will lead to OOM in most cases.
Having one long sequence in a dataset is enough for causing an OOM.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@qgallouedec qgallouedec changed the title Truncate by default ✂️ Truncate by default Jan 17, 2025
@qgallouedec qgallouedec requested review from kashif and lewtun January 17, 2025 15:54
@qgallouedec qgallouedec merged commit fd4b283 into main Jan 17, 2025
@qgallouedec qgallouedec deleted the truncate-by-default branch January 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants