🏛️ Improve DPO configuration documentation structure #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Jan 11, 2025
Comment on lines
-495
to
-500
| with self.assertRaisesRegex( | ||
| ValueError, | ||
| expected_regex=r"Can't find `pad_token_id` in the `processing_class`. " | ||
| r"Explicitly set `tokenizer.pad_token` \(e.g. `tokenizer.pad_token = tokenizer.eos_token`\) " | ||
| r"before instantiating the trainer.", | ||
| ): |
There was a problem hiding this comment.
probably an error: we aren't supposed to test this here, but the num_proc (test_dpo_trainer_w_dataset_num_proc)
qgallouedec
commented
Jan 11, 2025
Comment on lines
-460
to
-462
| expected_regex=r"Can't find `pad_token_id` in the `processing_class`. " | ||
| r"Explicitly set `tokenizer.pad_token` \(e.g. `tokenizer.pad_token = tokenizer.eos_token`\) " | ||
| r"before instantiating the trainer.", |
|
CI fails, I think we can ignore, see #2558 (comment) |
August-murr
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Cewl!
It would also be helpful to include instructions for generating the documentation in the contribution guideline
you know, for the community.🙄
…ingface/trl into better-structure-dpo-config
|
Good point, done in 43089fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before
After
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.