-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split and clean up GGUF quantization tests #35502
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Thanks for the cleanup
Signed-off-by: Isotr0py <[email protected]>
tests/quantization/ggml/test_ggml.py
Outdated
(QuantType.Q2_K.name, "Hello, I'm a 22 year old female"), | ||
(QuantType.Q3_K.name, "Hello\n\nI am trying to create a simple program that"), | ||
(QuantType.Q4_K.name, "Hello\n\nI am trying to create a simple program that"), | ||
(QuantType.Q5_K.name, "Helloveda is a 1999 Indian"), | ||
(QuantType.Q6_K.name, "Hello\n\nI am trying to create a simple program that"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use GGMLQuantizationType
to make sure it's a validated "pure" quantization type, because some models like Q4_K_M
means a combination of "mostly Q4_K" with some of other quantization, which shouldn't be used for quantization tests.
BTW, seems that this is causing tests_hub CI failing because gguf is not available on that CI, is there any way to solve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have this issue even if gguf is not available on the hub. There must be an issue when collecting tests with parameterized or maybe an issue with workflow of tests_hub. cc @ArthurZucker
Can you try to create a mapping instead so that you can replace GGMLQuantizationType by a string instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's use string for parameterize now! Also added a note to keep the quantization style aligned with gguf-py.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: Isotr0py <[email protected]>
What does this PR do?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @LysandreJik