Optimized set_initialized_submodules. #35493
Open
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an insanely slow function
set_initialized_submodules
, when loading DeepSeek V3, since it has so many experts, the amount ofstate_dict_keys
are huge and also there are a lot ofnamed_modules
.This line, especially
k.startswith(f"{module_name}.")
, gets called at least 1 million times, which is insanely slow, it takes at least 10 minutes runtime.My optimization reduces the runtime to less than 10 seconds by not iterating through
state_dict_keys
and deletingmodule_name
from the start for everynamed_module
, instead, it prepends themodule_name
before themodule.state_dict()
keys.cc: @ArthurZucker