Only import torch.distributed if it is available #35133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kwen2501 @ArthurZucker - I believe this is caused by the imports added in #34184 |
Yes, indeed. We vendored a simple patch in nixpkgs: https://github.com/NixOS/nixpkgs/pull/362768/files. |
ArthurZucker
approved these changes
Dec 10, 2024
ArthurZucker
pushed a commit
that referenced
this pull request
Dec 10, 2024
5 tasks
booxter
added a commit
to booxter/transformers
that referenced
this pull request
Jan 19, 2025
This is a continuation of 217c47e but for another module. This issue was spotted in nixpkgs (again) when building lm-eval package that used a different path in transformers library to reach the same failure. Related: huggingface#35133
SunMarc
pushed a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
torch.distributedis sometimes unavailable (on some platforms such as darwin).It leads to
transformers.models.auto.modeling_autoto fail to import with:I propose to implement a similar logic as in huggingface/accelerate#2121 to load
torch.distributedconditionally on its availability.I was able to test the patch in nixpkgs successfully.
Fixes #35129
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.