Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODULE] RAG Module #135

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[MODULE] RAG Module #135

wants to merge 19 commits into from

Conversation

duydl
Copy link
Collaborator

@duydl duydl commented Dec 22, 2024

No description provided.

@Knight7561
Copy link
Contributor

@duydl , Can I contribute to these module after checking out #85

davidberenstein1957
davidberenstein1957 reviewed Dec 30, 2024
View reviewed changes
8_rag/README.md Show resolved Hide resolved
8_rag/README.md Outdated

### RAG Architecture

RAG's modular architecture allows for customization and optimization based on task requirements. A typical RAG pipeline involves the following components:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps a visuals would help here?

8_rag/README.md Outdated Show resolved Hide resolved
8_rag/README.md Outdated Show resolved Hide resolved
@burtenshaw
Copy link
Collaborator

Hey @duydl ! Are you still working on this? It looks great so far.

@duydl duydl marked this pull request as ready for review January 12, 2025 20:10
@duydl
Copy link
Collaborator Author

duydl commented Jan 12, 2025 •
edited
Loading

@burtenshaw Hi. I am still working on this module. Sorry for the delay.
I usually use openAI model and rarely use SLM for RAG before so there was difficulty in making it working correctly for both retrieval and agent tool (in Langchain before and now in smolagent).
The markdown guides on the other hand are quite completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duydl @Knight7561 @burtenshaw @davidberenstein1957