Use process_retry on amd-smi #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
reviewed
Jan 27, 2025
| @@ -67,7 +67,7 @@ jobs: | |||
| options: --device /dev/kfd --device /dev/dri --env ROCR_VISIBLE_DEVICES --env HIP_VISIBLE_DEVICES --shm-size "16gb" --ipc host -v /mnt/cache/.cache/huggingface:/mnt/cache/ | |||
| steps: | |||
| - name: AMD-SMI | |||
| run: amd-smi list | |||
| run: python3 utils/process_retry.py 'amd-smi list' | |||
There was a problem hiding this comment.
better to update the repository before running this
There was a problem hiding this comment.
Don't forget to update this one before merge.
ydshieh
reviewed
Jan 27, 2025
| @@ -120,7 +120,7 @@ jobs: | |||
| echo "slice_ids=$(python3 -c 'd = list(range(${{ env.NUM_SLICES }})); print(d)')" >> $GITHUB_OUTPUT | |||
|
|
|||
| - name: AMD-SMI | |||
| run: amd-smi list | |||
| run: python3 utils/process_retry.py 'amd-smi list' | |||
There was a problem hiding this comment.
like this one being after name: Update clone
ydshieh
approved these changes
Jan 27, 2025
Yeah, most of those are from my IDE actually. It might be a bit too opinionated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
rocm-smiandamd-smi listrandomly fail on our runners.This should increase the odds of getting past those failures.