-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vision Transformer Introduction #380
Conversation
@johko @merveenoyan can you check if you are okay? |
Hey @sezan92 , sorry for the delay. We're currently working on moving the repo to the Hugging Face org here on GitHub for easier maintainability (and finally get the CI/CD error fixed). I think it is better to wait with the merging of your PR until the move has been finished, which should be in the next days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to rewrite these parts, I left some comments and suggestions for changes.
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Johannes Kolbe <[email protected]>
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
chapters/en/unit3/vision-transformers/vision-transformers-for-image-classification.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright LGTM now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for the updates
@johko Since the repository is now moved over to Hugging Face it looks like the only code owners are within Hugging Face so at this time they are the only ones who can merge. We might need to request that a couple more folks are given merge permission. |
Thanks for the hint, I'm on it |
Objective
This PR adds some extra details on Vision Transformer to the chapter "Vision Transcormer for Image Classification"