Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision Transformer Introduction #380

Merged
merged 8 commits into from
Feb 26, 2025
Merged

Vision Transformer Introduction #380

merged 8 commits into from
Feb 26, 2025

Conversation

sezan92
Copy link
Contributor

@sezan92 sezan92 commented Feb 3, 2025

Objective

This PR adds some extra details on Vision Transformer to the chapter "Vision Transcormer for Image Classification"

@sezan92
Copy link
Contributor Author

sezan92 commented Feb 17, 2025

@johko @merveenoyan can you check if you are okay?

@johko
Copy link
Collaborator

johko commented Feb 18, 2025

Hey @sezan92 , sorry for the delay. We're currently working on moving the repo to the Hugging Face org here on GitHub for easier maintainability (and finally get the CI/CD error fixed).

I think it is better to wait with the merging of your PR until the move has been finished, which should be in the next days.

Copy link
Collaborator

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to rewrite these parts, I left some comments and suggestions for changes.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sezan92 sezan92 requested a review from johko February 25, 2025 09:01
Copy link
Collaborator

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright LGTM now 👍

Copy link
Contributor

@ATaylorAerospace ATaylorAerospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the updates

@ATaylorAerospace
Copy link
Contributor

@johko Since the repository is now moved over to Hugging Face it looks like the only code owners are within Hugging Face so at this time they are the only ones who can merge. We might need to request that a couple more folks are given merge permission.

@johko
Copy link
Collaborator

johko commented Feb 26, 2025

@johko Since the repository is now moved over to Hugging Face it looks like the only code owners are within Hugging Face so at this time they are the only ones who can merge. We might need to request that a couple more folks are given merge permission.

Thanks for the hint, I'm on it

@johko johko merged commit b912ebf into huggingface:stage Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants