-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest bnb no longer has optim_args attribute on optimizer #3311
base: main
Are you sure you want to change the base?
Conversation
we might have to combine this with #3305 @bursteratom. I think 3305 isn't backwards compatible with older versions of bnb, but it also checks the lion optimizer case. |
@matthewdouglas Do you have time to check this? |
It's not immediately clear to me what could have changed on the bnb side. With that said, this still looks like a reasonable change to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, if @matthewdouglas is okay with this I am as well
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
with latest bitsandbytes:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr