Reduce durability.interval_ms lower bound to 1ms (NFSE-5140) (#178)

* Fix libmicrohttpd deprecation warnings (#169) Signed-off-by: Tristan Partin <[email protected]> (cherry picked from commit b16a16c) * Reduce durability.interval_ms lower bound to 1ms (NFSE-5140). (#177) Signed-off-by: Nabeel M Mohamed <[email protected]> (cherry picked from commit 96833e1) * Github workflow changes for 2.1.1 Signed-off-by: Nabeel M Mohamed <[email protected]> Co-authored-by: Tristan Partin <[email protected]>
hse-project · Jan 21, 2022 · e807eb1 · e807eb1
1 parent 90a1936
commit e807eb1
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 16 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -45,7 +45,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir -Dbuildtype=${{ matrix.buildtype }} --fatal-meson-warnings -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
+          meson builddir -Dbuildtype=${{ matrix.buildtype }} -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
 
       - name: Build
         run: |
@@ -96,7 +96,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir -Dbuildtype=${{ matrix.buildtype }} --fatal-meson-warnings -Dpmem=enabled -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
+          meson builddir -Dbuildtype=${{ matrix.buildtype }} -Dpmem=enabled -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
 
       - name: Build
         run: |
@@ -150,7 +150,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir -Dbuildtype=${{ matrix.buildtype }} --fatal-meson-warnings -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
+          meson builddir -Dbuildtype=${{ matrix.buildtype }} -Ddocs=disabled -Dbindings=all -Dycsb=true -Dwerror=true
 
       - name: Build
         run: |
@@ -201,7 +201,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir -Dbuildtype=${{ matrix.buildtype }} --fatal-meson-warnings -Ddocs=disabled -Dbindings=all -Dycsb=true -Db_sanitize=address,undefined
+          meson builddir -Dbuildtype=${{ matrix.buildtype }} -Ddocs=disabled -Dbindings=all -Dycsb=true -Db_sanitize=address,undefined
 
       - name: Build
         run: |

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -25,7 +25,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir --fatal-meson-warnings -Dwerror=true -Ddocs=enabled -Dtests=false -Dtools=disabled -Dbindings=none -Dcli=false -Dsamples=false -Ddb_bench=false
+          meson builddir -Dwerror=true -Ddocs=enabled -Dtests=false -Dtools=disabled -Dbindings=none -Dcli=false -Dsamples=false -Ddb_bench=false
 
       - name: Build
         run: |

diff --git a/.github/workflows/nightly_testing.yaml b/.github/workflows/nightly_testing.yaml
@@ -46,7 +46,7 @@ jobs:
 
       - name: Setup
         run: |
-          meson builddir -Dbuildtype=${{ matrix.build_type }} --fatal-meson-warnings -Dycsb=true
+          meson builddir -Dbuildtype=${{ matrix.build_type }} -Dycsb=true
 
       - name: Test
         run: |

diff --git a/lib/include/hse_ikvdb/wal.h b/lib/include/hse_ikvdb/wal.h
@@ -11,7 +11,7 @@
 #include <hse_ikvdb/kvs.h>
 #include <hse_ikvdb/tuple.h>
 
-#define HSE_WAL_DUR_MS_MIN         (25)
+#define HSE_WAL_DUR_MS_MIN         (1)
 #define HSE_WAL_DUR_MS_DFLT        (100)
 #define HSE_WAL_DUR_MS_MAX         (1000)
 

diff --git a/lib/util/src/rest_api.c b/lib/util/src/rest_api.c
@@ -29,19 +29,15 @@
 
 #include <bsd/string.h>
 #include <cjson/cJSON.h>
-#include <cjson/cJSON_Utils.h>
 
 #define SESSIONS_PER_THREAD 5
 #define NUM_THREADS 3
 #define MAX_SESSIONS (SESSIONS_PER_THREAD * NUM_THREADS)
 #define WQ_THREADS 5
 
-#ifndef MHD_HTTP_NOT_ACCEPTABLE
-#define MHD_HTTP_NOT_ACCEPTABLE MHD_HTTP_METHOD_NOT_ACCEPTABLE
-#endif
-
-#ifndef MHD_HTTP_TOO_MANY_REQUESTS
-#define MHD_HTTP_TOO_MANY_REQUESTS 429
+/* Required for building with libmicrohttpd >= 0.9.75 */
+#ifndef MHD_HTTP_UNPROCESSABLE_CONTENT
+#define MHD_HTTP_UNPROCESSABLE_CONTENT MHD_HTTP_UNPROCESSABLE_ENTITY
 #endif
 
 #define KV_PAIR_MAX 16
@@ -795,7 +791,7 @@ webserver_response(
 
     err = string_validate(path, REST_URL_LEN_MAX);
     if (ev(err)) {
-        http_status = MHD_HTTP_UNPROCESSABLE_ENTITY;
+        http_status = MHD_HTTP_UNPROCESSABLE_CONTENT;
         goto respond;
     }
 
@@ -853,7 +849,7 @@ webserver_response(
     MHD_get_connection_values(connection, MHD_GET_ARGUMENT_KIND, &extract_kv_pairs, session);
 
     if (ev(session->targ.iter.err)) {
-        http_status = MHD_HTTP_UNPROCESSABLE_ENTITY;
+        http_status = MHD_HTTP_UNPROCESSABLE_CONTENT;
         err = session->targ.iter.err;
         goto respond;
     }