use absolute value of pz to protect against minus infinity for rapidity #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for providing this code! I started playing a bit with the ParticleTransformer and ran into an issue of getting negative infinite values when pz is negative and very close in magnitude to the energy. The current implementation for calculating the rapidity protects against positive pz being close to energy, but not negative ones. This PR suggests using the absolute value and multiplying by the sign afterwards.