Feature: Model for statistics #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds test for creating audit events to existing test infrastructure.
Adds the model, migration and factory and updates the schema. Additionally, it introduces a "has_many" connection to the item model. It destroys the item with the audit events, because they won't be relevant anymore.
Introduces the audit event helper as interface for audit event. User are aware of available audit event types now.
Adds the creation of audit events to the existing infrastructure (mostly in item controller). Therefore, I had to disable the rubocop abc-metric for a function, because I couldn't reduce the complexity.
Introduces empty statistics helper to add functions for calculating statistics and metrices in the future.
I had to expand disabling the rubocop abc-metric for another function, because I couldn't reduce the complexity.
SaturnHafen
reviewed
Jan 6, 2023
spec/features/notifications/return_request_notifications_spec.rb
Outdated
Show resolved
Hide resolved
spec/features/notifications/return_request_notifications_spec.rb
Outdated
Show resolved
Hide resolved
Lietze
requested changes
Jan 6, 2023
Co-authored-by: Luke <[email protected]>
|
I'll clean the commit history with the squash 😇 I'm sorry for the mess |
Lietze
approved these changes
Jan 11, 2023
LucasDerReisende
approved these changes
Jan 11, 2023
SaturnHafen
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Looks good! I haven't confirmed if there are conflicts with @Greenscreen23's changes on dev. We should probably check that.
spec/features/notifications/return_request_notifications_spec.rb
Outdated
Show resolved
Hide resolved
spec/features/notifications/return_request_notifications_spec.rb
Outdated
Show resolved
Hide resolved
|
Thank you very much for the review again @SaturnHafen It's very helpful 😇 |
Co-authored-by: Lietze <[email protected]>
Co-authored-by: Luke <[email protected]>
LucasDerReisende
approved these changes
Jan 17, 2023
SaturnHafen
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138
This PR introduces audit event logs, to collect data of items for future statistics.
We can improve the performance in the future by calculating results of metrices on a regular basis with a cronjob.
PR checklist