Closing cards syncs with GitHub now

hpi-swa-teaching · Jun 1, 2024 · efd56a5 · efd56a5
1 parent 5d60201
commit efd56a5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/Squello-Core.package/SPBCard.class/instance/toggleClosed.st b/Squello-Core.package/SPBCard.class/instance/toggleClosed.st
@@ -2,5 +2,5 @@ updating
 toggleClosed
 
 	self isNote ifTrue: [^ self].
-	self flag: #todo. "actually close the card"
-	self isClosed: self isClosed not.
+	self isClosed: self isClosed not.
+	self boardProvider updateCard: self.
diff --git a/Squello-Core.package/SPBCard.class/methodProperties.json b/Squello-Core.package/SPBCard.class/methodProperties.json
@@ -83,7 +83,7 @@
 		"title:" : "mcr 5/21/2022 20:52",
 		"titleModel" : "tk 8/2/2022 23:24",
 		"titleModel:" : "tk 8/2/2022 23:24",
-		"toggleClosed" : "AH 5/25/2024 17:35",
+		"toggleClosed" : "AH 6/1/2024 18:27",
 		"update:with:" : "lo 8/3/2022 13:13",
 		"updateAssigneeCount" : "tk 8/2/2022 23:27",
 		"updateBalloonText" : "mcr 8/4/2022 01:50",

diff --git a/Squello-Core.package/SPBGithubBoardProvider.class/instance/updateCard..st b/Squello-Core.package/SPBGithubBoardProvider.class/instance/updateCard..st
@@ -7,5 +7,7 @@ updateCard: anSPBCard
 		payload := Dictionary newFrom: {'note' -> anSPBCard title}.
 		self api updateNote: anSPBCard id withPostData: payload.]
 	ifFalse: [
-		payload := Dictionary newFrom: {'title' -> anSPBCard title . 'body' -> anSPBCard description}.
+		| state |
+		state := anSPBCard isClosed ifTrue: ['closed'] ifFalse: ['open'].
+		payload := Dictionary newFrom: {'title' -> anSPBCard title . 'body' -> anSPBCard description . 'state' -> state}.
 		self api updateIssue: anSPBCard issueId withData: payload user: self user repo: self repo.].
diff --git a/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json b/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json
@@ -33,7 +33,7 @@
 		"renameColumn:to:" : "tk 7/30/2022 22:22",
 		"repo" : "mcr 5/22/2022 01:01",
 		"repo:" : "mcr 5/22/2022 01:02",
-		"updateCard:" : "FP 5/21/2024 11:22",
+		"updateCard:" : "AH 6/1/2024 18:31",
 		"user" : "mcr 5/22/2022 01:02",
 		"user:" : "mcr 5/22/2022 01:02",
 		"webhookId" : "NTK 7/30/2022 12:46" } }