Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8627 major valkey update #47

Merged
merged 2 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles/tldraw-server/templates/configmap.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
LOGGER_LOG_LEVEL: "{{ TLDRAW_LOG_LEVEL }}"
METRICS_COLLECT_DEFAULT: "{{ TLDRAW_METRICS_COLLECT_DEFAULT }}"
REDIS_CLUSTER_ENABLED: "true"
REDIS_SENTINEL_SERVICE_NAME: "valkey-headless.{{ NAMESPACE }}.svc.cluster.local"
REDIS_SENTINEL_SERVICE_NAME: "tldraw-valkey-headless.{{ NAMESPACE }}.svc.cluster.local"
TLDRAW_ASSETS_ALLOWED_MIME_TYPES_LIST: "{{ TLDRAW_ASSETS_ALLOWED_MIME_TYPES_LIST }}"
TLDRAW_ASSETS_ENABLED: "{{ TLDRAW_ASSETS_ENABLED }}"
FEATURE_TLDRAW_ENABLED: "{{ FEATURE_TLDRAW_ENABLED }}"
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/tldraw-valkey/defaults/main.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
TLDRAW_VALKEY_CHART_VERSION: 0.3.17
TLDRAW_VALKEY_CHART_VERSION: 2.2.1
TLDRAW_VALKEY_REPLICAS: 3
11 changes: 7 additions & 4 deletions ansible/roles/tldraw-valkey/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
kubernetes.core.helm:
chart_ref: oci://docker.io/bitnamicharts/valkey
chart_version: "{{ TLDRAW_VALKEY_CHART_VERSION }}"
release_name: valkey
release_name: tldraw-valkey
release_namespace: "{{ NAMESPACE }}"
release_state: present
create_namespace: yes
Expand All @@ -22,6 +22,8 @@
defaultStorageClass: "{{ SC_DEFAULT_STORAGE_CLASS_NAME }}"
replica:
replicaCount: "{{ TLDRAW_VALKEY_REPLICAS }}"
pdb:
create: false
resources:
limits:
cpu: "{{ TLDRAW_VALKEY_CPU_LIMITS|default('1000m', true) }}"
Expand All @@ -30,6 +32,10 @@
cpu: "{{ TLDRAW_VALKEY_CPU_REQUESTS|default('100m', true) }}"
memory: "{{ TLDRAW_VALKEY_MEMORY_REQUESTS|default('1Gi', true) }}"
primary:
pdb:
create: false
readinessProbe:
timeoutSeconds: 5
resources:
limits:
cpu: "{{ TLDRAW_VALKEY_CPU_LIMITS|default('1000m', true) }}"
Expand All @@ -40,9 +46,6 @@
auth:
existingSecret: tldraw-valkey-password
existingSecretPasswordKey: REDIS_SENTINEL_PASSWORD
master:
readinessProbe:
timeoutSeconds: 5
sentinel:
enabled: true
readinessProbe:
Expand Down
2 changes: 1 addition & 1 deletion src/infra/redis/redis.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class RedisConfig {
public REDIS_PREFIX = 'y';

@IsString()
public REDIS_SENTINEL_NAME = 'mymaster';
public REDIS_SENTINEL_NAME = 'myprimary';

@IsString()
@ValidateIf((o: RedisConfig) => o.REDIS_CLUSTER_ENABLED)
Expand Down
Loading