EW-1159: Fix RangeError for too many students in TSP Sync. (#5566)

* EW-1159: Fix RangeError for too many students in TSP Sync. * Add test. --------- Co-authored-by: Simone Radtke <[email protected]>
hpi-schul-cloud · Mar 6, 2025 · 7733840 · 7733840
1 parent 254f390
commit 7733840
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 13 deletions.
diff --git a/apps/server/src/infra/sync/strategy/tsp/tsp-oauth-data.mapper.spec.ts b/apps/server/src/infra/sync/strategy/tsp/tsp-oauth-data.mapper.spec.ts
@@ -166,6 +166,37 @@ describe(TspOauthDataMapper.name, () => {
 			});
 		});
 
+		describe('when handling large amounts', () => {
+			const setup = () => {
+				const system = systemFactory.build();
+
+				const school = schoolFactory.build({
+					externalId: faker.string.uuid(),
+				});
+
+				const lehrerUid = faker.string.uuid();
+
+				const tspTeachers = robjExportLehrerFactory.buildList(1000000, {
+					lehrerUid,
+					schuleNummer: school.externalId,
+				});
+
+				const tspClasses = [];
+
+				const tspStudents = robjExportSchuelerFactory.buildList(1000000);
+
+				return { system, school, tspTeachers, tspStudents, tspClasses };
+			};
+
+			it('should not throw RangeError', () => {
+				const { system, school, tspTeachers, tspStudents, tspClasses } = setup();
+
+				expect(() => sut.mapTspDataToOauthData(system, [school], tspTeachers, tspStudents, tspClasses)).not.toThrow(
+					RangeError
+				);
+			});
+		});
+
 		describe('when school has to externalId', () => {
 			const setup = () => {
 				const system = systemFactory.build();

diff --git a/apps/server/src/infra/sync/strategy/tsp/tsp-oauth-data.mapper.ts b/apps/server/src/infra/sync/strategy/tsp/tsp-oauth-data.mapper.ts
@@ -44,19 +44,22 @@ export class TspOauthDataMapper {
 		const oauthDataDtos: OauthDataDto[] = [];
 		const usersOfClasses = new Map<string, TspUserInfo[]>();
 
-		oauthDataDtos.push(
-			...this.mapTspTeachersToOauthDataDtos(
-				tspTeachers,
-				systemDto,
-				externalSchools,
-				externalClasses,
-				teacherForClasses,
-				usersOfClasses
-			)
-		);
-		oauthDataDtos.push(
-			...this.mapTspStudentsToOauthDataDtos(tspStudents, systemDto, externalSchools, externalClasses, usersOfClasses)
-		);
+		this.mapTspTeachersToOauthDataDtos(
+			tspTeachers,
+			systemDto,
+			externalSchools,
+			externalClasses,
+			teacherForClasses,
+			usersOfClasses
+		).forEach((oauthDataDto) => oauthDataDtos.push(oauthDataDto));
+
+		this.mapTspStudentsToOauthDataDtos(
+			tspStudents,
+			systemDto,
+			externalSchools,
+			externalClasses,
+			usersOfClasses
+		).forEach((oauthDataDto) => oauthDataDtos.push(oauthDataDto));
 
 		return { oauthDataDtos, usersOfClasses };
 	}