Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8974 change session cookie same site to lax #3598

Merged
merged 1 commit into from
Feb 18, 2025
Merged

BC-8974 change session cookie same site to lax #3598

merged 1 commit into from
Feb 18, 2025

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Feb 18, 2025

there is logic that encodes the oauth state into the sseion for thr and moin schule, thus when logging in the session info gets lost for the second request from a redirect (sorry hard to explain)

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-8974

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

there is logic that encodes the oauth state into the sseion for thr and moin schule, thus when logging in the session info gets lost for the second request from a redirect (sorry hard to explain)
@Loki-Afro Loki-Afro enabled auto-merge (squash) February 18, 2025 14:53
@Loki-Afro Loki-Afro merged commit 6b600a9 into main Feb 18, 2025
72 checks passed
@Loki-Afro Loki-Afro deleted the bc-8974 branch February 18, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants