Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8356 - Bettermarks and other oauth apps not openable if user double clicks on consent button #3586

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Feb 5, 2025

Description

User can have multiple pending requests at a time in the form that submits the consent for oauth operations (that affects at least bettermarks)

Links to Tickets or other pull requests

BC-8356

Changes

  • "Akzeptieren" button (see screenshot) will be disabled after first click, no option to send two requests anymore

Screenshots of UI changes

grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarqubecloud bot commented Feb 5, 2025

@MartinSchuhmacher MartinSchuhmacher merged commit fef6115 into main Feb 5, 2025
69 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the bettermarks-test branch February 5, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants