Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-1546 - Numbering, headings + tables does not work in tasks/topics/news #3405

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Feb 6, 2024

Description

Several formating issues when editing tasks, news and topics.
Formated text does not appear in view as supposed like in editor.

Links to Tickets or other pull requests

BC-1546

Changes

  • this covers news editor/view, task editor/view and topic editor/view
  • correct usage/formating of heading 1 -3
  • correct usage of table borders
  • correct usage of ordered lists

Screenshots of UI changes

grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

* this covers news editor/view, task editor/view and topic editor/view
@MartinSchuhmacher MartinSchuhmacher self-assigned this Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MartinSchuhmacher MartinSchuhmacher enabled auto-merge (squash) February 9, 2024 06:54
@MartinSchuhmacher MartinSchuhmacher merged commit 947f053 into main Feb 9, 2024
40 of 41 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-1546-formating-issues branch February 9, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants